-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Bevy 0.12 #29
Conversation
I haven't looked much into the code, but by running this branch it seems shadows are gone :( (I'm not up to date with bevy versions so i'm not sure what may be happening). |
Cool, I sort of expected problems based on how hairy the shader migration was. This is also my first encounter with your project. I'll compare the output to the bevy 0.11 version later and try to figure out what's going on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Please add mention of your migration work on the README for credit if you feel like it
Will do. Should probably still wait on bevy_atmostphere. |
Thanks! |
This is incomplete. Still working through shader migrations. But the project compiles.
I will pick this up again later if nobody else beats me to it. (Other users: feel free to make a PR to the
bevy-0.12
branch of my fork)