Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bevy 0.12 #29

Merged
merged 9 commits into from
Nov 15, 2023
Merged

Upgrade to Bevy 0.12 #29

merged 9 commits into from
Nov 15, 2023

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Nov 8, 2023

This is incomplete. Still working through shader migrations. But the project compiles.

I will pick this up again later if nobody else beats me to it. (Other users: feel free to make a PR to the bevy-0.12 branch of my fork)

@rparrett
Copy link
Contributor Author

rparrett commented Nov 8, 2023

Okay, this is in a generally working state now, but I have a feeling that what I did in the shaders was a bit of a hack job. I really have very little idea of what is going on in there.

Also, bevy_atmosphere needs to do a release because this currently depends on an unmerged migration for that plugin.

image

@rparrett rparrett marked this pull request as ready for review November 8, 2023 18:27
@Game4all
Copy link
Owner

Game4all commented Nov 9, 2023

I haven't looked much into the code, but by running this branch it seems shadows are gone :( (I'm not up to date with bevy versions so i'm not sure what may be happening).

@rparrett
Copy link
Contributor Author

rparrett commented Nov 9, 2023

Cool, I sort of expected problems based on how hairy the shader migration was.

This is also my first encounter with your project. I'll compare the output to the bevy 0.11 version later and try to figure out what's going on.

@Game4all
Copy link
Owner

Game4all commented Nov 9, 2023

Here's a screenshot of master
image

Copy link
Owner

@Game4all Game4all left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Please add mention of your migration work on the README for credit if you feel like it

@rparrett
Copy link
Contributor Author

rparrett commented Nov 11, 2023

Will do. Should probably still wait on bevy_atmostphere.

@Game4all Game4all merged commit 4799fd0 into Game4all:master Nov 15, 2023
3 checks passed
@Game4all
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants